Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

You left that PR open for 7 days before closing it?

Average PR lifetime in ziglang/zig repo itself is about 12 days. This is actually pretty fast compared to other projects. I'm proud of the fact that the oldest open PR in zig is from October 2, 2020 - only 2 months and 11 days old.

From the perspective of someone submitting a pull request, it's frustrating to not get a response within a day or two. I completely get that. But it's just not possible when you have a team of 1-3 people who are able to engage with PRs, and hundreds of people submitting PRs.

Since this project has started, the Earth has completed 1732 rotations, and yet 2877 pull requests have been closed. That's 1.7 per day, including weekends and holidays. Consider that for the first couple of years of this project, I was moonlighting it with a day job.

I'm not trying to throw shade at you, just saying, man, cut me some slack. I'll get to your PR.



I had been unaware of the volume of PRs that you receive, apologies, I had thought that my PR was just ignored.

Thanks for your reply and thank you for Zig.

I'll reopen that particular issue, and will try to fix any example zig apps that I can't compile, and will submit PRs for them.


I look forward to merging them :)




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: