> If code reviewers share responsibility for the code they review, why on earth would anyone review code?
Ok, and if there are no shared responsibility, then what’s to stop the reviewers from just mindlessly clicking “approve” to shut the person up? I know for a fact that that happens all the time.
> If you were told that your code was sloppy, and if your performance review was affected by it, maybe it was sloppy code?
Sure, but again, isn’t “sloppy code” the lowest hanging fruit for a code reviewer? If the PR process doesn’t spot that, what exactly does it offer?
> But to say that your responsibility is lessened because it was blessed by code reviewers and they should share in your punishment, is, frankly, immature
I think we are just going to have to agree to disagree on this. If you are signing off on something, you are attaching your name and credibility towards it. I didn’t really want any of the reviewers to get into “trouble”, but i do think they should share a percentage of the responsibility on breakage if I am going to get in trouble if they signed off on something that was “sloppy”.
Ok, and if there are no shared responsibility, then what’s to stop the reviewers from just mindlessly clicking “approve” to shut the person up? I know for a fact that that happens all the time.
> If you were told that your code was sloppy, and if your performance review was affected by it, maybe it was sloppy code?
Sure, but again, isn’t “sloppy code” the lowest hanging fruit for a code reviewer? If the PR process doesn’t spot that, what exactly does it offer?
> But to say that your responsibility is lessened because it was blessed by code reviewers and they should share in your punishment, is, frankly, immature
I think we are just going to have to agree to disagree on this. If you are signing off on something, you are attaching your name and credibility towards it. I didn’t really want any of the reviewers to get into “trouble”, but i do think they should share a percentage of the responsibility on breakage if I am going to get in trouble if they signed off on something that was “sloppy”.